Docstring for show_versions in master #33108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 29, 2020
jreback
requested changes
Mar 29, 2020
| @@ -88,6 +88,20 @@ def _get_dependency_info() -> Dict[str, JSONSerializable]: | |||
|
|
|||
|
|
|||
| def show_versions(as_json: Union[str, bool] = False) -> None: | |||
| """ | |||
| Provides useful information, important for bug reports. | |||
There was a problem hiding this comment.
remove this first sentence and replace with the 2nd.
There was a problem hiding this comment.
@jreback, I originally had it in the form as you suggest, but the 2nd sentence is too long to be in one line, and it is not allowed to have the heading in 2 lines.
|
As @MomIsBestFriend mentions #33073 (comment), you can just update #33073 and merge master into that branch. Let's continue development in #33073 and address @jreback's comments there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff