Fix mixup between mean and median #33106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text said "median", but code uses "mean". Make text match the code
mroeschke
reviewed
Mar 29, 2020
| @@ -386,4 +386,4 @@ A full overview on time series is given in the pages on :ref:`time series and da | |||
|
|
|||
| .. raw:: html | |||
|
|
|||
| </div> | |||
There was a problem hiding this comment.
Hmm what changed here? Could you revert this diff?
There was a problem hiding this comment.
The editor (I used the GitHub website) appended a newline here, so that the file ends with a newline. I'd suggest to leave it in, otherwise the next person trying to edit this file with GitHub will run into the same issue.
Or would you prefer a separate PR to fix the file endings? It looks like most, but not all, other files in the Pandas docs already end with a newline. (Some also with multiple newlines...)
|
thanks @oefe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text said "median", but code uses "mean". Make text match the code
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff