-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add index option to_markdown() #33091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. can you add a release note in other enhancements for 1.1 ping on green.
@jreback apparently, the |
@quangngd can you merge master. |
…into to_markdown-index
@quangngd can you update as @TomAugspurger suggests (will need to change the test as well) |
How tests should handle warnings? |
Sure! There is a note on the contributing guide here: https://pandas.pydata.org/docs/dev/development/contributing.html#testing-warnings Can you merge master + get a green CI? |
@alimcmaster1 i don't know what to do with the codecov/patch fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @quangngd for working on this. can you update the parameters section of the docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quangngd still need to update the docstring #33091 (review)
Co-authored-by: Simon Hawkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, pls merge master and ping on green.
can you merge master and address comments |
thanks @quangngd |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff