ERR: Raise NotImplementedError with BaseIndexer and certain rolling operations #33057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mroeschke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-28 20:52:23 UTC |
mroeschke
added
Error Reporting
jreback
requested changes
Mar 27, 2020
jreback
requested changes
Mar 28, 2020
pandas/core/window/rolling.py
Outdated
| @@ -145,6 +145,20 @@ def _validate_get_window_bounds_signature(window: BaseIndexer) -> None: | |||
| f"get_window_bounds" | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _validate_baseindexer_support(window, func_name: Optional[str]) -> None: | |||
There was a problem hiding this comment.
either make this a method or just a module level free function ; i find static methods are
non obvious to grok
There was a problem hiding this comment.
Done. Created a common function instead of a static method
jreback
approved these changes
Mar 29, 2020
|
thanks @mroeschke |
5 tasks
This was referenced Apr 17, 2020
AlexKirko
added a commit
to AlexKirko/pandas
that referenced
this pull request
Apr 26, 2020
…olling operations (pandas-dev#33057)" This reverts commit 2bf54a8.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAs a temporary solution for returning incorrect results when using a BaseIndexer subclass with certain rolling operations, a
NotImplementedErrorwill now raise with instructions to useapplyinstead.