-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[WIP] Make Index.values read-only #33055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ivirshup are you still interested in working on this? |
I've gotten a little stuck on the cython part. Using the cython 3.0 alpha, the errors about using a I think it could make sense for someone who has more experience with cython to take over, or at least figure out that part. I'm still interested, but I'm not sure I have the time to learn that much about cython at the moment. |
see if you can merge master and get this passing |
c01c14b
to
5014559
Compare
5014559
to
e1fda5b
Compare
@@ -33,6 +33,20 @@ def test_mutability(index): | |||
index[0] = index[0] | |||
|
|||
|
|||
def test_values_mutability(index): | |||
if not len(index): | |||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moot point till tests are passing, but ideally should use pytest.skip with message.
closing as inactive, we can reopen if you like after cy3 is available. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
This is a PR for looking around enforcing immutability of
pd.Index
objects. It will be a draft, but the main idea is to show what tests fail and what would need to change for this to be implemented. Because of this, I'm going to add some commits incrementally, so there is a history in the build logs.