-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Added RuntimeWarning to lib.fast_unique_multiple #33015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 24 commits into
pandas-dev:master
from
ShaharNaveh:TODO-runtimewarning-_libs-lib
Apr 2, 2020
Merged
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a8cbc37
Added RuntimeWarning to lib.fast_unique_multiple
28871d1
isort
3db5519
Fixed test case to be lib specific
8a7f6c9
Warning error message
9ce23ab
Not asserting the warning if on numpy_dev
d57aded
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
1c3a45f
Troubleshoot failing test
9db8893
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
ab8cc80
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
d186e6d
Added information on how to suppress the warning
df301eb
Troubleshoot failing test
fde1e1a
Update pandas/_libs/lib.pyx
ShaharNaveh 6d1508d
Marked failed test as xfail
1314e99
Marked xfailed-strict as False
f29760c
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
e55bc81
Troubleshoot failing test
d2cd2d9
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
b931025
Removed if statement related to numpy-dev
2c05ed2
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
17a6f99
Added whatsnew
b7ace2b
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
83e2e82
What's new refrence to this PR
564d416
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
63a6104
Merge remote-tracking branch 'upstream/master' into TODO-runtimewarni…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test this from an end user perspective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above