Skip to content

TST: Move _get_cython_table_params into pandas/_testing.py #32981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

TST: Move _get_cython_table_params into pandas/_testing.py #32981

merged 1 commit into from
Mar 24, 2020

Conversation

SaturnFromTitan
Copy link
Contributor

Part of #30914

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@SaturnFromTitan SaturnFromTitan added the Testing pandas testing functions or related to the test suite label Mar 24, 2020
@jbrockmendel
Copy link
Member

LGTM

jreback
jreback approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@jreback jreback added this to the 1.1 milestone Mar 24, 2020
@jreback jreback merged commit 6a84598 into pandas-dev:master Mar 24, 2020
@jreback
Copy link
Contributor

jreback commented Mar 24, 2020

thanks @SaturnFromTitan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SaturnFromTitan @jbrockmendel @jreback