Skip to content

TST: Use indices fixture in tests/indexes/test_setops.py #32964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SaturnFromTitan
Copy link
Contributor

part of #30914

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@SaturnFromTitan SaturnFromTitan added the Testing pandas testing functions or related to the test suite label Mar 24, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SaturnFromTitan lgtm

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 24, 2020
@jbrockmendel
Copy link
Member

LGTM

@SaturnFromTitan SaturnFromTitan force-pushed the 30914-use-indices-fixture-in-tests-indexes-test_setops branch from 69aea98 to 5bb42d8 Compare March 25, 2020 18:37
@jreback jreback merged commit c6179ce into pandas-dev:master Mar 26, 2020
@jreback
Copy link
Contributor

jreback commented Mar 26, 2020

thanks @SaturnFromTitan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants