CLN/STY: Nitpicks #32961
CLN/STY: Nitpicks #32961
Conversation
Things I find myself doing in multiple branches
| @@ -454,7 +463,7 @@ cdef class DatetimeEngine(Int64Engine): | |||
|
|
|||
| cdef class TimedeltaEngine(DatetimeEngine): | |||
|
|
|||
| cdef _get_box_dtype(self): | |||
| cdef str _get_box_dtype(self): | |||
| return 'm8[ns]' | |||
There was a problem hiding this comment.
not gonna change to double-quotes while you're here?
|
Looks fine. Brainstorming ideas for expanding the range of what you work on: when editing a file, consider searching for TODO/FIXME comments and seeing if any of them are things you can address. (best case is right at the edge of what you're comfortable with). E.g. there is one TODO in index.pyx that looks doable. |
| def rank_1d( | ||
| rank_t[:] in_arr, | ||
| ties_method="average", | ||
| bint ascending=True, |
| ties_method="average", | ||
| bint ascending=True, | ||
| na_option="keep", | ||
| bint pct=False, |
| ascending=True, na_option='keep', pct=False): | ||
| def rank_2d( | ||
| rank_t[:, :] in_arr, | ||
| int axis=0, |
| rank_t[:, :] in_arr, | ||
| int axis=0, | ||
| ties_method="average", | ||
| bint ascending=True, |
| ties_method="average", | ||
| bint ascending=True, | ||
| na_option="keep", | ||
| bint pct=False, |
|
I forgot to mention the changes I've made which are not related to styling. @jbrockmendel @WillAyd Can you please re-review? |
|
Personally, I would stop doing such styling changes to cython (to resemble what black does) until there is black support for cython at which point we can do it in one go and consistently. |
Noted. |
|
thanks @MomIsBestFriend yeah let's hold off on cython changes for style until we have an auto formatter, however typing / fixing things are all ok. |
Things I find myself doing in multiple branches