-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: df.iloc[:, :1] with EA column #32959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fb8d7ce
BUG: df.iloc[:, :1] with EA column
jbrockmendel 0a28719
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 628e242
Fix test, remove DatetimeTZBlock._slice
jbrockmendel 36ff3a7
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 1400f23
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 338c8ab
improved check, docstring
jbrockmendel f032bd8
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 81b9555
check earlier, flesh out tests
jbrockmendel 53455fe
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel e465651
remove is_extension check
jbrockmendel 5f5945e
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 86fffb7
whatsnew
jbrockmendel 0304962
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 527e9cb
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 02f0be8
extra test with [:, -1:]
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,34 @@ def test_iloc_frame(self, data): | |
result = df.iloc[:4, 0] | ||
self.assert_series_equal(result, expected) | ||
|
||
# GH#32959 slice columns with step | ||
result = df.iloc[:, ::2] | ||
self.assert_frame_equal(result, df[["A"]]) | ||
result = df[["B", "A"]].iloc[:, ::2] | ||
self.assert_frame_equal(result, df[["B"]]) | ||
|
||
def test_iloc_frame_single_block(self, data): | ||
# GH#32959 null slice along index, slice along columns with single-block | ||
df = pd.DataFrame({"A": data}) | ||
|
||
result = df.iloc[:, :] | ||
self.assert_frame_equal(result, df) | ||
|
||
result = df.iloc[:, :1] | ||
self.assert_frame_equal(result, df) | ||
|
||
result = df.iloc[:, :2] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add some There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated+green |
||
self.assert_frame_equal(result, df) | ||
|
||
result = df.iloc[:, ::2] | ||
self.assert_frame_equal(result, df) | ||
|
||
result = df.iloc[:, 1:2] | ||
self.assert_frame_equal(result, df.iloc[:, :0]) | ||
|
||
result = df.iloc[:, -1:] | ||
self.assert_frame_equal(result, df) | ||
|
||
def test_loc_series(self, data): | ||
ser = pd.Series(data) | ||
result = ser.loc[:3] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also put this check in
getitem_block
or_slice_take_blocks_ax0
to ensure that_slice
always gets the correct tuple of slices?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, directly check the value? As here you convert it to a len-2 tuple, and then in a next step, you convert the tuple back to a slice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm one way to avoid this PITA would be to have 2D EAs...