Skip to content

CLN: Remove encoding specifier #32955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@@ -1,6 +1,4 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this shebang?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to do this as follow up PR, trying to have each PR for specific thing.

@jbrockmendel
Copy link
Member

LGTM

@WillAyd
Copy link
Member

WillAyd commented Mar 25, 2020

What is the point of doing this?

@jbrockmendel
Copy link
Member

What is the point of doing this?

I'm pretty sure this is a py2 holdover

@ShaharNaveh
Copy link
Member Author

What is the point of doing this?

I'm pretty sure this is a py2 holdover

Correct, there is no need to specify the encoding (if it's utf8), in python3

@jreback jreback added this to the 1.1 milestone Mar 26, 2020
@jreback jreback merged commit 0cf3491 into pandas-dev:master Mar 26, 2020
@jreback
Copy link
Contributor

jreback commented Mar 26, 2020

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CLN-encoding-py2 branch March 26, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants