REF: move mixed-dtype frame_apply check outside of _reduce try/except #32950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't reproduce this test failure locally |
|
Maybe add a test specifically for the median of a dataframe with categorical columns, so it might be clearer what is wrong with that (as I suppose that is the reason that the |
jreback
added
Clean
Numeric Operations
|
btw I think we simply need to create pandas.core.reduce, similiar to how we have pandas.core.apply to handle all of this logic. much easier to reason about in a separate module (and can easily break down / dispatch cases). |
|
thanks, pls note potential followon above... |
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jul 3, 2020
…y/except (pandas-dev#32950)" This reverts commit b838508.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jorisvandenbossche this is the same branch I linked the other day. Some variant of #32867 may make this irrelevant, but I don't think getting this improvement in the interim will make that any more difficult.