CLN: remove unnecessary Series._convert calls #32949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Mar 24, 2020
jorisvandenbossche
requested changes
Mar 24, 2020
| @@ -1342,14 +1342,10 @@ def first_not_none(values): | |||
|
|
|||
| # values are not series or array-like but scalars | |||
| else: | |||
| # only coerce dates if we find at least 1 datetime | |||
| should_coerce = any(isinstance(x, Timestamp) for x in values) | |||
There was a problem hiding this comment.
Does this change behaviour?
| @@ -386,7 +386,7 @@ def _wrap_aggregated_output( | |||
| result = self._wrap_series_output( | |||
| output=output, index=self.grouper.result_index | |||
| ) | |||
| return self._reindex_output(result)._convert(datetime=True) | |||
| return self._reindex_output(result) | |||
There was a problem hiding this comment.
Do you have an explanation of why this is not needed anymore?
There was a problem hiding this comment.
No, just an observation that we dont have any tests that break without it.
jreback
approved these changes
Mar 24, 2020
|
Brock, can you respond to my comments? |
|
can you merge master, this looks ok. I guess @jorisvandenbossche has some comments |
|
this is fine |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd my confidence on the correctness here is only "pretty sure", so could use an extra set of eyes.