CLN: xarray tests #32943
CLN: xarray tests #32943
Conversation
`DeprecationWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.`
| def test_to_xarray_index_types(self, indices): | ||
| if isinstance(indices, pd.MultiIndex): | ||
| pytest.skip("MultiIndex is tested separately") | ||
|
|
||
| from xarray import DataArray | ||
|
|
||
| s = Series(range(len(indices)), index=indices) | ||
| s = Series(range(len(indices)), index=indices, dtype="float64") |
There was a problem hiding this comment.
why is this change needed?
There was a problem hiding this comment.
To suppress the Deprecation warning
DeprecationWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.
There was a problem hiding this comment.
Is this the only place this occurs? I assume we are getting an empty container through from indices
I'd be surprised if this is the only case, so not sure doing as a one-off here
There was a problem hiding this comment.
Is this the only place this occurs? I assume we are getting an empty container through from indices
I'd be surprised if this is the only case, so not sure doing as a one-off here
@WillAyd This is the only case in this file that raises the deprecation warning.
There was a problem hiding this comment.
I can revert this change, not a deal breaker for me
|
LGTM |
| def test_to_xarray_index_types(self, indices): | ||
| if isinstance(indices, pd.MultiIndex): | ||
| pytest.skip("MultiIndex is tested separately") | ||
|
|
||
| from xarray import DataArray | ||
|
|
||
| s = Series(range(len(indices)), index=indices) | ||
| s = Series(range(len(indices)), index=indices, dtype="float64") |
There was a problem hiding this comment.
Is this the only place this occurs? I assume we are getting an empty container through from indices
I'd be surprised if this is the only case, so not sure doing as a one-off here
simonjayhawkins
added
Clean
Testing
|
Thanks @MomIsBestFriend |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff