TST: move to indices fixture instead of create_index #32916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_tolist_matches_list(indices): | ||
| assert indices.tolist() == list(indices) | ||
| class TestRendering: | ||
| def test_str(self, indices): |
There was a problem hiding this comment.
hmm, may need to rethink this test now testing over all indexes since "tuples": MultiIndex.from_tuples(zip(["foo", "bar", "baz"], [1, 2, 3])), so "foo" is already in str(indices)
|
|
||
| @pytest.mark.parametrize("label", [1.0, "foobar", "xyzzy", np.nan]) | ||
| def test_isin_level_kwarg_bad_label_raises(self, label, indices): | ||
| index = indices | ||
| if isinstance(index, MultiIndex): | ||
| index = index.rename(["foo", "bar"]) | ||
| index = index.rename(["foo", "bar"] + index.names[2:]) |
There was a problem hiding this comment.
hmm, I think the intention of the explicitly renaming was to ensure that the labels being tested were not already in the index.
simonjayhawkins
added
the
Testing
simonjayhawkins
approved these changes
Mar 23, 2020
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.