-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add ods writer #32911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ENH: Add ods writer #32911
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
526d756
WIP: unit tests are still failing for ods write to ods read loop back…
roberthdevries 165d887
Create empty cells where needed
roberthdevries 024cb2d
Add support for dates
roberthdevries 341b77c
More date/datetime fixes
roberthdevries 1ead9f0
Make sure the cells and columns are sorted before writing them out
roberthdevries df321b6
Pass explicit engine for reading ods files
roberthdevries fbc5b3e
Only check extensions when there is a file with an extension
roberthdevries 1303b85
Fix #N/A handling
roberthdevries 4cae564
Add support for merged cells and skipped rows
roberthdevries bd78fae
Clean up code
roberthdevries 5b9427f
Implement styling
roberthdevries 3a8a06b
Refactor a bit to make a bit more readable
roberthdevries 4d6ca30
black reformatting
roberthdevries 736ec57
flake8 and isort fixes
roberthdevries 9458d4f
Typing validation fixes
roberthdevries ac0c96f
Fix typo in type annotation
roberthdevries 1fdabc6
Remove commented out debug code
roberthdevries 149e1c5
Move imports inside methods
roberthdevries defb5c1
Move skip into test
roberthdevries af530a4
mypy fix
roberthdevries febd3ba
Add whatsnew entry
roberthdevries dac7cb6
Simplify datetime formatting by removing useless check
roberthdevries d64fb96
Add support for startrow and startcol arguments
roberthdevries 54fbbf8
Add automatic OpenDocument Spreadsheet recognition to ExcelFile class
roberthdevries d6e48fb
Improve import dependency parameterization
roberthdevries 635dd84
Reformatting fixes (black)
roberthdevries 2de7755
Rename parameter path_or_io to path_or_buffer
roberthdevries 19f0a5c
Add doc-strings and type annotations
roberthdevries 89f742f
Update whatsnew according to suggestion by jreback
roberthdevries 171fc61
Black reformatting
roberthdevries 0d15a20
Fix some type annotations
roberthdevries 336c231
Some type fixes
roberthdevries 3edfbd8
Revert some of the typing fixes as they break some of the builds
roberthdevries 97707b8
More mypy typing fixes
roberthdevries 45467d2
Add more typing info
roberthdevries b14847d
And yet more typing fixes
roberthdevries d4d3a7c
Add doc-string and type info to _is_ods_stream
roberthdevries f82f4d4
Fix import order
roberthdevries f20e2cc
Add test to check exception when writing in append mode
roberthdevries 9e2684f
Add whatsnew entry for extra bug fix in read_excel for 0.0 values in …
roberthdevries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than this should register the writer globally
pandas/pandas/core/config_init.py
Line 576 in 120e9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The weird thing is that this stuff does not seem to be used anywhere. Correct me if I'm wrong. I added a similar bit for the OpenOffice file format, but it did not seem to be called/tested anywhere.