EHN: to_{html, string} col_space col specific #32903
Conversation
quangngd
changed the title
quangngd
changed the title
|
@quangngd you still interested in working on this? |
alimcmaster1
added
IO HTML
Yes, Im still waiting for feedbacks |
quangngd
changed the title
|
Tests added for to_string. |
|
@quangngd - thanks for the PR mind fixing up the test failures? |
|
@alimcmaster1 done |
|
cc @WillAyd @simonjayhawkins for a look |
| if col_space is None: | ||
| self.col_space = {} | ||
| elif isinstance(col_space, (int, str)): | ||
| self.col_space = {"": col_space} |
There was a problem hiding this comment.
Minor but you can just create the dict inline using a comprehension on one line instead of doing this then calling update on the next
There was a problem hiding this comment.
@WillAyd The "" (empty) key is for the row id column. Couldn't think of how to turn this into a oneliner?
| @@ -702,7 +733,7 @@ def _to_str_columns(self) -> List[List[str]]: | |||
| """ | |||
| # this method is not used by to_html where self.col_space | |||
| # could be a string so safe to cast | |||
| self.col_space = cast(int, self.col_space) | |||
| col_space = {k: cast(int, v) for k, v in self.col_space.items()} | |||
There was a problem hiding this comment.
Is the cast still required here?
There was a problem hiding this comment.
@WillAyd Not an actual cast, typing.cast just used to signal to the type checker (mypy). In this case self.col_space can be of type dict<str> by definition but we are sure that it is dict<int> within this scope
|
Great PR - thanks a lot @quangngd ! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIn to_html, to_latex and to_string,
col_spacearg now accepts a list or dict where we can mention the column name to change only a specific column's width.Haven't add test for to_latex and to_string since they too don't have test for the old col_space and I cannot think of anything less cumbersome than to count added whitespace.