Skip to content

TST: test that the .copy method on indexes copy the cache #32898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2020

Conversation

topper-123
Copy link
Contributor

In #32883 I made a PR to fix an issue that MultiIndex.copy didn't copy the _cache.

This adds a test for this for all index types (there's no futher issue, but it should still be tested for).

@topper-123 topper-123 changed the title TST: test that Index.copy copies the cache TST: test that the .copy method on indexes copy the cache Mar 21, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Mar 21, 2020
@WillAyd WillAyd added this to the 1.1 milestone Mar 21, 2020
@jreback jreback merged commit 4c05c07 into pandas-dev:master Mar 22, 2020
@jreback
Copy link
Contributor

jreback commented Mar 22, 2020

thanks @topper-123

@topper-123 topper-123 deleted the copy_cache branch March 22, 2020 01:15
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants