Skip to content

REF: simplify should_extension_dispatch, remove dispatch_to_extension_op #32892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

jbrockmendel
Copy link
Member

dispatch_to_extension_op was needed back before we got rid of integer-addition for DTA/TDA/Timestamp/Timedelta. Now it reduces to a one-liner, which this inlines.

This also consolidates all of the casting/checks up-front, which in turn avoids a runtime import and simplifies the check for should_extension_dispatch.

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code labels Mar 21, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. small comment

@jreback jreback added this to the 1.1 milestone Mar 22, 2020
@jreback jreback merged commit fddaa99 into pandas-dev:master Mar 22, 2020
@jreback
Copy link
Contributor

jreback commented Mar 22, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-ops-2 branch March 22, 2020 00:37
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants