TST: Replace tm.all_index_generator with indices fixture #32886
Conversation
SaturnFromTitan
added
Clean
Testing
|
Originally I wanted to implement
But then I realised that all places where |
| @@ -240,17 +243,9 @@ def test_to_xarray_index_types(self, index): | |||
| tm.assert_series_equal(result.to_series(), s, check_index_type=False) | |||
|
|
|||
| @td.skip_if_no("xarray", min_version="0.7.0") | |||
| def test_to_xarray(self): | |||
| def test_to_xarray_multiindex(self): | |||
There was a problem hiding this comment.
Potentially this could benefit from using the MultiIndex cases from indices. I didn't want to include it in this PR though
| and isinstance(obj, pd.DataFrame) | ||
| ): | ||
| # TODO: Seems to be bugged | ||
| pytest.xfail("This doesn't raise") |
There was a problem hiding this comment.
Wasn't sure what to do here. Is this ok or should this be fixed? I added an xfail for now, but can create a follow-up issue
There was a problem hiding this comment.
can you split this to a separate test for now (and just xfail the entire test; we can come back later and fix), but rather not add this code. also create an issue (and reference it here).
| and isinstance(obj, pd.DataFrame) | ||
| ): | ||
| # TODO: Seems to be bugged | ||
| pytest.xfail("This doesn't raise") |
There was a problem hiding this comment.
can you split this to a separate test for now (and just xfail the entire test; we can come back later and fix), but rather not add this code. also create an issue (and reference it here).
| @@ -261,3 +256,15 @@ def test_to_xarray(self): | |||
| tm.assert_almost_equal(list(result.coords.keys()), ["one", "two"]) | |||
| assert isinstance(result, DataArray) | |||
| tm.assert_series_equal(result.to_series(), s) | |||
|
|
|||
| @td.skip_if_no("xarray", min_version="0.7.0") | |||
There was a problem hiding this comment.
cc @jbrockmendel your test moving PR for xrray might need rebasing after this
There was a problem hiding this comment.
actually i think we always have a > 0.7.0 xarary?
There was a problem hiding this comment.
I can check that as a follow-up. There are more spots where this condition is used
|
@jreback CI is green |
|
thanks @SaturnFromTitan |
Inspired by #30999
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff