TST: add test for non UTC datetime split #14042 #32866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 20, 2020
mroeschke
reviewed
Mar 20, 2020
|
|
||
| def test_split_non_utc(self): | ||
| indices = pd.date_range("2016-01-01 00:00:00+0200", freq="S", periods=10) | ||
| split_indices = np.split(indices, indices_or_sections=[]) |
There was a problem hiding this comment.
Could you name these variables result and expected so the comparison below can be
tm.assert_index_equal(result, expected)
There was a problem hiding this comment.
are there enough functions like np.split to merit a file like tests.indexes.datetimes.test_numpy_compat?
There was a problem hiding this comment.
@mroeschke right, done.
@jbrockmendel np.split is the only function I know for which such an issue occurred. But this is my first PR for this project so maybe there are others that I haven't noticed.
mroeschke
added
the
Testing
| "2016-01-01 00:00:08+02:00", | ||
| "2016-01-01 00:00:09+02:00", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
this is the same as indices but without a a freq, right? if so, can you construct it as
expected = index.copy()
expected._set_freq(None)
|
thanks @JDkuba |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff