BUG: Fix read_csv IndexError crash for c engine with header=None and 2 (or more) extra columns #32839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberthdevries
changed the title
roberthdevries
force-pushed
the
fix-26128-read_csv-crash-c-engine-header-None-2-extra-columns
branch
from
241fcfc to
440470e
Compare
jreback
requested changes
Mar 21, 2020
pandas/_libs/parsers.pyx
Outdated
| @@ -1316,8 +1316,8 @@ cdef class TextReader: | |||
| else: | |||
| if self.header is not None: | |||
| j = i - self.leading_cols | |||
| # hack for #2442 | |||
| if j == len(self.header[0]): | |||
| # hack for #2442 and #26218 | |||
There was a problem hiding this comment.
can you remove the 'hack' word; rather put an explan what is happening here
gfyoung
reviewed
Mar 21, 2020
… more) extra columns
Co-Authored-By: gfyoung <[email protected]>
roberthdevries
force-pushed
the
fix-26128-read_csv-crash-c-engine-header-None-2-extra-columns
branch
from
606fd84 to
2ba6a4d
Compare
jreback
approved these changes
Mar 22, 2020
|
thanks @roberthdevries |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
…2 (or more) extra columns (pandas-dev#32839)
roberthdevries
deleted the
fix-26128-read_csv-crash-c-engine-header-None-2-extra-columns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff