ERR: Better error message for missing columns in aggregate #32836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to user non-existing columns causing error Line too long - corrected What's New Updated Tests Fixed testing errors
jreback
changed the title
jreback
added
Apply
jreback
requested changes
Mar 21, 2020
| @@ -356,7 +356,11 @@ def _aggregate(self, arg, *args, **kwargs): | |||
| if isinstance(obj, ABCDataFrame) and len( | |||
| obj.columns.intersection(keys) | |||
| ) != len(keys): | |||
| raise SpecificationError("nested renamer is not supported") | |||
| cols = sorted(set(keys) - set(obj.columns.intersection(keys))) | |||
There was a problem hiding this comment.
its not worth it dispatching on both, just make. single message
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -84,7 +84,7 @@ Other API changes | |||
| - Added :meth:`DataFrame.value_counts` (:issue:`5377`) | |||
| - :meth:`Groupby.groups` now returns an abbreviated representation when called on large dataframes (:issue:`1135`) | |||
| - ``loc`` lookups with an object-dtype :class:`Index` and an integer key will now raise ``KeyError`` instead of ``TypeError`` when key is missing (:issue:`31905`) | |||
| - | |||
| - :meth:`DataFrame.agg` now provides more descriptive SpecificationError message when attempting to aggregating non-existant column (:issue:`32755`) | |||
There was a problem hiding this comment.
can you move this to reshaping
|
merge master to fix the docs issue |
|
@jreback Made changes and green |
jreback
approved these changes
Mar 22, 2020
|
thanks @JDTruj2018 |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More descriptive SpecificationError message that reports to user non-existing columns causing error
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff