-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: skip non-consolidatable blocks when checking consolidation #32826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: skip non-consolidatable blocks when checking consolidation #32826
Conversation
With:
it gives
|
Very nice @jorisvandenbossche , thanks! I can confirm that when cherry-picked on top of #32825 this gives another 2x speed-up,
So around 14x speed-up for these 3 PRs. |
Looks like a nice speedup. Couple of questions, non-blockers:
|
Not specific to SparseArray, it's for all non-consolidatable blocks (which is now just ExtensionBlock I think?) I suppose that we can get rid of |
@jbrockmendel updated with removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice cleanup
thanks @jorisvandenbossche yeah we had removed ftypes in 1.0, so this was a leftover i think. |
This skips the non-consolidatable blocks to determine if the blocks are consolidated. So meaning that if you have multiple EA columns with the same dtype, we do not do an unnecessary consolidation.
From investigating #32196 (comment)
@rth this should give another speed-up to your benchmark