TST: Avoid bare pytest.raises in multiple files #32816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 10, 2020 21:05
Found a type-o in one of the error messages and corrected it.
� Conflicts: � pandas/tests/dtypes/test_dtypes.py
They got undone due to new commits to pandas.
…999_disallow_bare_pytest_raises_test_indexing
…999_disallow_bare_pytest_raises_test_indexing
…999_disallow_bare_pytest_raises_misc
…999_disallow_bare_pytest_raises_misc � Conflicts: � pandas/tests/dtypes/test_dtypes.py
…999_disallow_bare_pytest_raises_misc
This reverts commit 20094d9 This is handled in another file and is awaiting approval.
simonjayhawkins
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Thanks @Vlek lgtm ex @jorisvandenbossche comments (improving error messages could be follow-on)
simonjayhawkins
added
the
Testing
Co-Authored-By: Simon Hawkins <[email protected]>
… pull pandas-dev#32816 by jorisvandenbossche.
…999_disallow_bare_pytest_raises_misc
…s_misc' into 30999_disallow_bare_pytest_raises_misc
…ng of the error messages.
jorisvandenbossche
changed the title
added 2 commits
March 20, 2020 20:12
test_replace.py based on feedback received from jorisvandenbossche.
…999_disallow_bare_pytest_raises_misc
|
Thanks @Vlek |
sthagen
added a commit
to sthagen/pandas-dev-pandas
that referenced
this pull request
Mar 21, 2020
TST: Avoid bare pytest.raises in multiple files (pandas-dev#32816)
4 tasks
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref [Good first issue] TST: Disallow bare pytest.raises #30999
tests added / passed
passes
black pandaspasses
git diff upstream/master -u -- "*.py" | flake8 --diff