CLN: remove DatetimeLikeArray._add_delta #32799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 19, 2020
|
|
||
| def _add_delta_tdi(self, other): | ||
| """ | ||
| Add a delta of a TimedeltaIndex | ||
| return the i8 result view | ||
|
|
There was a problem hiding this comment.
hmm, this name now looks confusing (because of the word delta), maybe
_add_timedeltaindex
There was a problem hiding this comment.
changed to add_timedelta_arraylike
jreback
approved these changes
Mar 19, 2020
|
thanks. I think could type these functions pretty easily now :-> |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately we want to 1) avoid using _from_sequence (so we can make that stricter in what it accepts) and 2) be more careful about when we use
freq="infer". Splitting up the cases handled by _add_delta will make this more feasible.