Skip to content

BUG: created check and warning for merging dataframes on unequal inde… #32796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SeeminSyed
Copy link

@SeeminSyed SeeminSyed commented Mar 18, 2020

…x levels (#13094)

@pep8speaks
Copy link

Hello @SeeminSyed! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 186:9: E265 block comment should start with '# '
Line 191:13: E128 continuation line under-indented for visual indent
Line 208:1: W293 blank line contains whitespace

# warn user when merging between different levels
# warn users when merging between different index levels
if _left.index.nlevels != _right.index.nlevels:
msg = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment `# GH#[relevant_issue]"

@@ -182,6 +182,32 @@ def test_drop_api_equivalence(self):
with pytest.raises(ValueError):
df.drop(axis=1)

def test_merge_join_different_index_levels(self):
#GH 13094
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after "#", can fix with black pandas

@simonjayhawkins
Copy link
Member

Thanks @SeeminSyed closing as stale. ping to re-open.

@simonjayhawkins simonjayhawkins added Error Reporting Incorrect or improved errors from pandas Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR: warning on merging on unequal levels for an Index
5 participants