Skip to content

BLD: Suppressing warnings when compiling pandas/_libs/writers #32795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

BLD: Suppressing warnings when compiling pandas/_libs/writers #32795

merged 1 commit into from
Mar 18, 2020

Conversation

ShaharNaveh
Copy link
Member

  • ref Error on C Warnings #32163
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This is the error that this PR is getting rid of:

pandas/_libs/writers.c: In function ‘__pyx_pw_6pandas_5_libs_7writers_1write_csv_rows’:
pandas/_libs/writers.c:3435:15: warning: ‘__pyx_v_j’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 3435 |     __pyx_t_1 = (__pyx_v_j + 1);
      |     ~~~~~~~~~~^~~~~~~~~~~~~~~~~
pandas/_libs/writers.c:2911:14: note: ‘__pyx_v_j’ was declared here
 2911 |   Py_ssize_t __pyx_v_j;
      |              ^~~~~~~~~

@ShaharNaveh ShaharNaveh added the Build Library building on various platforms label Mar 18, 2020
@WillAyd WillAyd added this to the 1.1 milestone Mar 18, 2020
WillAyd
WillAyd approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbrockmendel
Copy link
Member

LGTM pending green

@WillAyd WillAyd merged commit 3df837a into pandas-dev:master Mar 18, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 18, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the BLD-silence-bld-warnings-writers branch March 18, 2020 09:44
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@ShaharNaveh @SeeminSyed
BLD: Suppressing warnings when compiling pandas/_libs/writers (pandas…
49350bd 
…-dev#32795)
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
@ShaharNaveh @jbrockmendel
BLD: Suppressing warnings when compiling pandas/_libs/writers (pandas…
a5535b9 
…-dev#32795)
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 25, 2020
@ShaharNaveh @jbrockmendel
BLD: Suppressing warnings when compiling pandas/_libs/writers (pandas…
0a42227 
…-dev#32795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaharNaveh @jbrockmendel @WillAyd