ERR: Raise on invalid na_action in Series.map #32790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do any Index methods need the same fix? |
Looks like they do. Actually it seems worse, e.g. Edit: Tried fixing this and wasn't able to without introducing more bugs. Opened this issue instead: #32815. |
jreback
requested changes
Mar 19, 2020
pandas/core/base.py
Outdated
| map_f = lib.map_infer | ||
| else: | ||
| raise ValueError("na_action must either be 'ignore' or None") |
There was a problem hiding this comment.
add: f`{na_action} was passed
jreback
reviewed
Mar 19, 2020
| @@ -787,3 +787,9 @@ def test_map_float_to_string_precision(self): | |||
| result = ser.map(lambda val: str(val)).to_dict() | |||
| expected = {0: "0.3333333333333333"} | |||
| assert result == expected | |||
|
|
|||
| def test_map_with_invalid_na_action_raises(self): | |||
| s = pd.Series([1, 2, 3]) | |||
There was a problem hiding this comment.
add the issue umber as a comment
jreback
approved these changes
Mar 21, 2020
@jreback Merged master and green, thanks for reviewing |
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffSeries.maptreats anyna_actionother than"ignore"likeNone, but it should probably raise if someone provides an invalid option: