Skip to content

CLN: .values -> ._values #32778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Mar 26, 2020
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
0be1713
CLN: avoid _ndarray_values
jbrockmendel Feb 28, 2020
e9e5db8
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Feb 28, 2020
953b04c
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Feb 29, 2020
f70e15d
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Feb 29, 2020
6197fbc
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Feb 29, 2020
6db54bd
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 1, 2020
4a1088e
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 2, 2020
3a4e2a2
more _values
jbrockmendel Mar 3, 2020
b0b024b
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
ed65b44
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
c92858a
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
ebaec34
_ndarray_values->asi8
jbrockmendel Mar 3, 2020
c2d5b1b
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
12ea11c
typo
jbrockmendel Mar 3, 2020
9f2b6ef
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
f7805b8
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
130c3e6
_ndarray_values->np.asarray
jbrockmendel Mar 3, 2020
5e8dcb6
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 3, 2020
63b05c6
unnecessary values_from_object calls
jbrockmendel Mar 3, 2020
c9989e2
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 4, 2020
92983f0
comments
jbrockmendel Mar 4, 2020
f32a1a0
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 4, 2020
d4a420b
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 5, 2020
35d3fdd
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 5, 2020
65f005f
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 6, 2020
201ca4e
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 6, 2020
cf9b479
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 6, 2020
d43348a
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 7, 2020
ee3a5b0
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 7, 2020
b0acf4c
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 7, 2020
ef05d7d
move comments to collect branch
jbrockmendel Mar 7, 2020
d5b5730
values->_values
jbrockmendel Mar 7, 2020
be0d40a
values->_values
jbrockmendel Mar 8, 2020
dce37dd
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 9, 2020
4fd7e62
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 11, 2020
8fa2dc0
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 11, 2020
8bcd1df
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 11, 2020
a13b6dc
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 11, 2020
61835a5
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 12, 2020
3971791
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 12, 2020
a49a3a6
checkpoint passing
jbrockmendel Mar 13, 2020
b9be012
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 13, 2020
11020b9
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 15, 2020
ed9ba9d
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 15, 2020
df25c00
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 17, 2020
f3a4d38
values-> _values
jbrockmendel Mar 17, 2020
6cb81b7
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 17, 2020
dc58813
.values->._values
jbrockmendel Mar 17, 2020
01b98c2
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 24, 2020
18e713a
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Mar 25, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/indexes/category.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,11 @@ def _simple_new(cls, values: Categorical, name: Label = None):

@Appender(Index._shallow_copy.__doc__)
def _shallow_copy(self, values=None, name: Label = no_default):
name = self.name if name is no_default else name

if values is not None:
values = Categorical(values, dtype=self.dtype)

return super()._shallow_copy(values=values, name=name)

def _is_dtype_compat(self, other) -> bool:
Expand Down