TYP: PandasObject._cache #32775
Merged
TYP: PandasObject._cache #32775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +65,7 @@ def __repr__(self) -> str: | |||
| # Should be overwritten by base classes | |||
| return object.__repr__(self) | |||
|
|
|||
| def _reset_cache(self, key=None): | |||
| def _reset_cache(self, key: Optional[str] = None) -> None: | |||
There was a problem hiding this comment.
do we ever actually pass a key?
There was a problem hiding this comment.
Twice, both times in groupby/groupby.py.
|
Just out of curiosity why do you think this is better placed in PandasObject? |
|
My motivation is to have it set on the same class as _reset_cache is set on, because those two belong logically together. This would also prevent that _cache attribute is set on a child class that is incompatible with _reset_cache. |
|
thanks @topper-123 |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
_cache: Dict[str, Any]fragment to PandasObject, where it belongs + related changes.