copy license text from: tidyverse/haven #32756
Conversation
The existing HAVEN_LICENSE file was lacking any form of actual license. After checking the pandas source, it appears that the reference to HAVEN is in relation to tidyverse/haven, copying the license from tidyverse/haven for clarity. Signed-off-by: Jamin Collins <[email protected]>
|
For reference, can you dig up the commit in haven adding their license? When we added the test files, Haven apparently didn't include a license yet: #26537 (comment) |
|
Looks like the license was added as a result of this PR: and this commit: |
|
The PR to add here predates the change to add the license, so I don't think should be retro-fitting that here, no? |
|
It was noted in this comment #26537 (comment), that the project (haven) appeared to be under MIT. The next comment #26537 (comment) indicates that (hadley) is fine with that. The PR that I reference tidyverse/haven#484 was merged by what appears to be the same individual. However, the files in this project do no reflect the MIT license. This is simply an attempt to clarify what was (apparently) already recorded separately. |
|
this is fine. cc @TomAugspurger |
|
Yep, LGTM. I just wanted the verification that we didn’t fail to copy the license initially.
… On Mar 16, 2020, at 21:46, Jeff Reback ***@***.***> wrote:
this is fine. cc @TomAugspurger
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Thanks @jamin-aws-ospo ! |
The existing HAVEN_LICENSE file was lacking any form of actual license.
After checking the pandas source, it appears that the reference to HAVEN
is in relation to tidyverse/haven, copying the license from
tidyverse/haven for clarity.
Signed-off-by: Jamin Collins [email protected]