FIX: series.fillna doesn't shallow copy if len(series) == 0 #32733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is an empty Series
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32733 in repo pandas-dev/pandas |
SaturnFromTitan
force-pushed
the
32543-obj-fillna-fill_value-doesn-t-shallow-copy-if-obj-is-an-empty-series
branch
from
0d6f740 to
93797f4
Compare
jreback
requested changes
Mar 16, 2020
jreback
added
the
Missing-data
|
@jreback Adapted the isnew section and CI is green |
|
@jreback btw, is there any chance I could get privileges to run |
|
@SaturnFromTitan added you to pandas-triage you can now label & close issues (i think u can prob trigger CI not sure about that) |
|
sweet, thanks a lot @jreback! |
WillAyd
approved these changes
Mar 16, 2020
|
Great thanks @SaturnFromTitan and congrats on the triage role - well deserved! |
|
Thanks for the kind words @WillAyd :) |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff