Skip to content

CLN: Switch to using is not None rather than bool() #32721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2020
Merged

CLN: Switch to using is not None rather than bool() #32721

merged 1 commit into from
Mar 15, 2020

Conversation

skasturi
Copy link
Contributor

@skasturi skasturi commented Mar 15, 2020 •
edited
Loading

@skasturi skasturi changed the title Switch to using is not None rather than bool() Switch to using is not None rather than bool() Mar 15, 2020
@skasturi skasturi changed the title Switch to using is not None rather than bool() Switch to using is not None rather than bool() for checking an object being not None Mar 15, 2020
@skasturi skasturi changed the title Switch to using is not None rather than bool() for checking an object being not None CLN: Switch to using is not None rather than bool() for checking an object being not None Mar 15, 2020
@skasturi skasturi changed the title CLN: Switch to using is not None rather than bool() for checking an object being not None CLN: Switch to using is not None rather than bool() Mar 15, 2020
topper-123
topper-123 approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@topper-123 topper-123 added this to the 1.1 milestone Mar 15, 2020
@topper-123 topper-123 merged commit e5cd7b1 into pandas-dev:master Mar 15, 2020
@topper-123
Copy link
Contributor

Thanks, @skasturi.

sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Mar 15, 2020
@sthagen
Merge pull request #93 from pandas-dev/master
a2d2a43 
Switch to using is not None (pandas-dev#32721)
@skasturi skasturi deleted the skasturi/switch_to_is_not_none branch March 15, 2020 16:59
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@skasturi @SeeminSyed
Switch to using is not None (pandas-dev#32721)
2cc1b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Possible code improvement suggestion: Use is not None rather than bool() for None check
2 participants
@skasturi @topper-123