Skip to content

CLN: remove SingleBlockManager._values #32716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 17, 2020
Merged

CLN: remove SingleBlockManager._values #32716

merged 5 commits into from
Mar 17, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@topper-123 topper-123 added this to the 1.1 milestone Mar 15, 2020
topper-123
topper-123 approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jreback
jreback requested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, i actually think this is worse as we are now peering into internal state. We should use the internals api in any callers, esp groupby.

@jbrockmendel
Copy link
Member Author

hmm, i actually think this is worse as we are now peering into internal state. We should use the internals api in any callers, esp groupby.

Just implemented with much better alternative: use obj._values like we do everywhere else

@jreback
Copy link
Contributor

jreback commented Mar 17, 2020

lgtm. merge on green.

@jbrockmendel jbrockmendel merged commit 68f3efe into pandas-dev:master Mar 17, 2020
@jbrockmendel jbrockmendel deleted the cln-smgr-_values branch March 17, 2020 16:41
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@jbrockmendel @SeeminSyed
CLN: remove SingleBlockManager._values (pandas-dev#32716)
012ca23 
* CLN: remove SingleBlockManager._values

* obj._data._block.values -> obj._values
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
@jbrockmendel
CLN: remove SingleBlockManager._values (pandas-dev#32716)
f2e8139 
* CLN: remove SingleBlockManager._values

* obj._data._block.values -> obj._values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @topper-123