CLN: Prelims for stronger typing in Block methods #32712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 15, 2020
| @@ -872,6 +872,7 @@ def __getitem__(self, key): | |||
|
|
|||
| if com.is_bool_indexer(key): | |||
| key = check_bool_indexer(self.index, key) | |||
| key = np.asarray(key, dtype=bool) | |||
There was a problem hiding this comment.
doesn’t check_bool_indexer guarantee this?
There was a problem hiding this comment.
i was surprised by this too, but no
There was a problem hiding this comment.
ok, let's investigate if we can do this inside check_bool_indexer (either open an issue or do as a followon)
jreback
approved these changes
Mar 16, 2020
| @@ -872,6 +872,7 @@ def __getitem__(self, key): | |||
|
|
|||
| if com.is_bool_indexer(key): | |||
| key = check_bool_indexer(self.index, key) | |||
| key = np.asarray(key, dtype=bool) | |||
There was a problem hiding this comment.
ok, let's investigate if we can do this inside check_bool_indexer (either open an issue or do as a followon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.