Skip to content

CLN: unnecessary usages of Block.get_values #32707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2020
Merged

CLN: unnecessary usages of Block.get_values #32707

merged 3 commits into from
Mar 14, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added the Clean label Mar 14, 2020
@jreback jreback added this to the 1.1 milestone Mar 14, 2020
@jreback jreback added the Internals Related to non-user accessible pandas implementation label Mar 14, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2020

lgtm - can you merge master? I don't think pipelines ran

@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

FYI you can add a comment /azp run to trigger azure (and check on a non-rebasd PR)

@WillAyd WillAyd merged commit 9e9785b into pandas-dev:master Mar 14, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2020

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the get_values-no-dtype branch March 14, 2020 21:41
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@jbrockmendel @SeeminSyed
CLN: avoid Block.get_values where it is unnecessary (pandas-dev#32707)
7cd22ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback