Track times #32700
Track times #32700
Conversation
|
https://www.pytables.org/usersguide/libref/file_class.html?highlight=create_table#tables.File.create_table this option already defaults to |
Yes, you are right. The default value is The possibility to set of track_times can be seen in test on line 325. And on lines 340 and 343 you can see the different or the same check-sums after appropriate setup of track_times. |
rbenes
force-pushed
the
track_times
branch
2 times, most recently
from
18654d9 to
88eea0e
Compare
pandas/io/pytables.py
Outdated
| from tables import __version__ as tables_version | ||
| from packaging.version import Version | ||
|
|
||
| if Version(tables_version) >= Version("3.4.3"): |
There was a problem hiding this comment.
changed. Thanks for hint. But, what is the reason for using LooseVersion? I found that packaging.version is more "modern" - https://stackoverflow.com/a/11887885/1386342
pandas/io/pytables.py
Outdated
| @@ -4140,6 +4145,17 @@ def write( | |||
| # set the table attributes | |||
| table.set_attrs() | |||
|
|
|||
| if track_times is not None: | |||
| from tables import __version__ as tables_version | |||
| from packaging.version import Version | |||
There was a problem hiding this comment.
this import can be at the top (but use LooseVersion)
There was a problem hiding this comment.
Moved. LooseVersion used.
There was a problem hiding this comment.
I had to revert
from tables import __version__ as tables_version
back here because of:
Checks on imported code1s
##[error]Process completed with exit code 2.
Run source activate pandas-dev
Check import. No warnings, and blacklist some optional dependencies
err: pandas should not import: tables, numexpr
Check import. No warnings, and blacklist some optional dependencies DONE
##[error]Process completed with exit code 2.
pandas/io/pytables.py
Outdated
|
|
||
| if Version(tables_version) >= Version("3.4.3"): | ||
| options["track_times"] = track_times | ||
| else: |
There was a problem hiding this comment.
Yes. Ignored. It is now much easier.
| # GH 32682 | ||
| # enables to set track_times (see `pytables` `create_table` documentation) | ||
|
|
||
| import hashlib |
There was a problem hiding this comment.
all imports should be at the top; if you need to skip for a version you can do it with a @td.skip_if_no. add a test for >= 3.4.3 and one fore before that.
|
Hi @jreback . I did changes you requested. But, I found another possibility - not to pass track_times in parameters but put it here: https://pandas.pydata.org/pandas-docs/stable/user_guide/options.html . What do you think? |
i think accepting it like in this pr is ok. |
rbenes
force-pushed
the
track_times
branch
5 times, most recently
from
36f1c07 to
f134442
Compare
I updated requirements in separate PR and updated this PR accordingly. |
|
Hi, I see that "krysma" already remind this feature. Please revise changes and decide next steps. I synced it with master, so now it is without conflicts. |
| @@ -984,6 +984,7 @@ def put( | |||
| data_columns: Optional[List[str]] = None, | |||
| encoding=None, | |||
| errors: str = "strict", | |||
| track_times: bool = True, | |||
There was a problem hiding this comment.
can you update the doc-string, make sure to add a 1.1 versionadded tag
rbenes
force-pushed
the
track_times
branch
2 times, most recently
from
7c9661c to
a5b46df
Compare
|
thanks @rbenes |
|
Hi, trying to use track_times=False I add to look at all the options used in the test, so that I found that index=None is needed in order to indeed obtain reproducible files. |
I implement feature request #32682 but if someone has more experience with pytables consider these changes.
The h5 files generated with track_times=False has the same md5 hashes, that is covered in the unit test as well as the fact that the hashes are not the same with track_times=True
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff