Skip to content

CLN: avoid _ndarray_values in reshape.merge #32693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2020
Merged

CLN: avoid _ndarray_values in reshape.merge #32693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,10 +1657,13 @@ def _get_merge_keys(self):
def _get_join_indexers(self):
""" return the join indexers """

def flip(xs):
def flip(xs) -> np.ndarray:
""" unlike np.transpose, this returns an array of tuples """
xs = [
x if not is_extension_array_dtype(x) else x._ndarray_values for x in xs
x
if not is_extension_array_dtype(x)
else extract_array(x)._values_for_argsort()
for x in xs
]
labels = list(string.ascii_lowercase[: len(xs)])
dtypes = [x.dtype for x in xs]
Expand Down