Skip to content

REF: values-> _values #32662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2020
Merged

REF: values-> _values #32662

merged 2 commits into from
Mar 14, 2020

Conversation

jbrockmendel
Copy link
Member

For the affected Index subclasses .values and ._values are the same

@jbrockmendel jbrockmendel changed the title No values ci REF: values-> _values Mar 12, 2020
@jbrockmendel
Copy link
Member Author

@WillAyd tangential to this PR: in io.json._json there are a couple of uses of obj.values; is it clear whether those can be changed to obj._values?

@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2020

I don't know all of the differences between the two enough to say for sure but I would think so

@jbrockmendel
Copy link
Member Author

I don't know all of the differences between the two enough to say for sure but I would think so

Yah it can be hard to keep track of. Rule of thumb: ._values is non-lossy and non-copying, .values may doesn't assure either for EA Series/Index.

I'll try to changing those two usages and see if it breaks anything.

@jreback jreback added the Refactor Internal refactoring of code label Mar 14, 2020
@jreback jreback added this to the 1.1 milestone Mar 14, 2020
@jreback jreback merged commit fa26bce into pandas-dev:master Mar 14, 2020
@jbrockmendel jbrockmendel deleted the no-values-ci branch March 14, 2020 03:14
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@jbrockmendel @SeeminSyed
values->_values (pandas-dev#32662)
d46cd83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback