-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: process Int64 as ints for preservable ops, not as float64 #32652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7538352
to
9804f2c
Compare
@jorisvandenbossche Yeah, I agree this isn't the long-term approach. The issue is that |
9804f2c
to
a2aaa3d
Compare
so would be ok with this for only min/max right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this invades way toomuch on group/frame ops. this should all be pushed back down to the EA ops. So this might require multiple PRs to handle this.
a2aaa3d
to
db1344a
Compare
@jreback Updated to the bare minimum to fix |
we are likey to merge: #30982 shortly. Happy to take this as a followon using that approach. |
@qwhelen does #30982 affect the implementation here? |
@jbrockmendel Looks like this is unnecessary now, closing |
Calling
.min()
or.max()
onpd.Int64
data returns integers, but usesfloat64
as an intermediate representation, leading to data corruption.This PR attempts to whitelist them to be processed entirely as
Int64
s. Also add a test that verifies this behavior, as existing tests failed to detect the bug.black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff