Skip to content

DOC: fix formatting / links of API refs in 1.0.2 whatsnew #32620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

jorisvandenbossche
Copy link
Member

cc @TomAugspurger (did a few other clean-ups directly as well)

@jorisvandenbossche jorisvandenbossche added this to the 1.0.2 milestone Mar 11, 2020
- Fixed regression in :meth:`pandas.core.groupby.RollingGroupby.apply` where the ``raw`` parameter was ignored (:issue:`31754`)
- Fixed regression in :meth:`pandas.core.window.Rolling.corr` when using a time offset (:issue:`31789`)
- Fixed regression in :meth:`pandas.core.groupby.DataFrameGroupBy.nunique` which was modifying the original values if ``NaN`` values were present (:issue:`31950`)
- Fixed regression in ``groupby(..).rolling(..).apply()`` (``RollingGroupby``) where the ``raw`` parameter was ignored (:issue:`31754`)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RollingGroupby is not included in our API docs, so can't link to it

@@ -64,7 +65,6 @@ Bug fixes

**Datetimelike**

- Bug in :meth:`DataFrame.reindex` and :meth:`Series.reindex` when reindexing with a tz-aware index (:issue:`26683`)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to regressions, as this also fixed a regression (initially only a bug, but was backported later)

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@TomAugspurger TomAugspurger merged commit c1fd95b into pandas-dev:master Mar 11, 2020
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 11, 2020

Thanks.

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 11, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 c1fd95bece36815d7b3fa09f1e103a5218c5f5e9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #32620: DOC: fix formatting / links of API refs in 1.0.2 whatsnew'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-32620-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #32620 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@TomAugspurger
Copy link
Contributor

I'll backport this manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants