Skip to content

DOC: Validating that the word pandas is correctly capitalized #32613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 29 commits into from
Closed

DOC: Validating that the word pandas is correctly capitalized #32613

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
591cdc6
Fixed wrong diff
joybh98 Mar 17, 2020
4665b01
added requested changes
joybh98 Mar 24, 2020
019544a
added -R and PANDAS
joybh98 Mar 31, 2020
0fbdf48
CI: add doctest check for done modules (#33175)
ShaharNaveh Mar 31, 2020
927dedb
REF: .get tests (#33164)
jbrockmendel Mar 31, 2020
eab7226
CLN: using C-API of datetime (#33174)
ShaharNaveh Mar 31, 2020
e56d395
DOC: Partial fix SA04 errors in docstrings #28792 (feedback needed) (…
Mar 31, 2020
cc3f3eb
REF: fillna tests (#33183)
jbrockmendel Mar 31, 2020
4d0eef6
Json parametrize more2 (#33163)
WillAyd Mar 31, 2020
cb41651
CLN: use ._data less in reshape (#33159)
jbrockmendel Mar 31, 2020
51f114b
BUG: isna_old with td64, dt64tz, period (#33158)
jbrockmendel Mar 31, 2020
aa71c21
REF: .drop tests (#33156)
jbrockmendel Mar 31, 2020
a7dd3ea
REF: test_reindex_like (#33150)
jbrockmendel Mar 31, 2020
f10ec59
BUG: create new MI from MultiIndex._get_level_values (#33134)
topper-123 Mar 31, 2020
6a8aca9
BUG: to_datetime with infer_datetime_format dropped timezone names (#…
mroeschke Mar 31, 2020
c166013
DOC: Fix capitalization of doc section headers (#33149)
themien Mar 31, 2020
a6c610d
DOC: Fix capitalization of docs section headers (#32944)
themien Mar 31, 2020
8305a85
DOC: Fix PR06 (type names) in docstrings (#33093)
farhanreynaldo Mar 31, 2020
98a2aa3
TST: cover search_sorted scalar mixed timezones case (#33185)
jamescobonkerr Mar 31, 2020
f148cb7
DOC: Added docstring for show_versions() (#33073)
MarianD Mar 31, 2020
cbd1103
REF: set_axis tests (#33189)
jbrockmendel Mar 31, 2020
1357114
ENH/VIZ: Allowing `s` parameter of scatter plots to be a column name …
SultanOrazbayev Mar 31, 2020
f303665
misplaced sort-index test (#33191)
jbrockmendel Apr 1, 2020
af0c878
Correct docstring to describe actual functionality. (#33190)
tv3141 Apr 1, 2020
d8d1dc9
REF/CLN: test_get_dummies (#33184)
jbrockmendel Apr 1, 2020
49bc8d8
TYP: require _update_inplace gets Frame/Series, never BlockManager (#…
jbrockmendel Apr 1, 2020
8c73b5f
fixed merge conflicts
joybh98 Apr 1, 2020
6daedb0
All changes in a single commit
joybh98 Apr 1, 2020
b332532
fixed merge conflict in test_unstack.py
joybh98 Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ci/code_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ if [[ -z "$CHECK" || "$CHECK" == "lint" ]]; then
flake8-rst doc/source --filename=*.rst --format="$FLAKE8_FORMAT"
RET=$(($RET + $?)) ; echo $MSG "DONE"

# Check if pandas is referenced as pandas, not *pandas* or Pandas
MSG='Checking if pandas reference is standardized or not' ; echo $MSG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MSG='Checking if pandas reference is standardized or not' ; echo $MSG
MSG='Checking if the pandas word is always used lowercase (has to be pandas, not Pandas or PANDAS...)' ; echo $MSG

grep -nr '*pandas*|Pandas' doc/*
grep -nr '*pandas*|Pandas' web/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the next code works. You can't have two statements, since you are checking the exit code later, and you're only checking the code of the last statement.

Suggested change
grep -nr '*pandas*|Pandas' web/*
grep -nr '*pandas*|Pandas' web/* doc/*

Also, please use invgrep as in the rest of this script, you're doing here the opposite of what you want to do. And we have lots of validations where we already do this for other patterns, don't need to reinvent the wheel, just so the same, so we also keep consistent.

RET=$(($RET + $?)) ; echo $MSG "DONE"


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave extra blank lines, keep the same style and formatting as the rest of the script.

# Check that cython casting is of the form `<type>obj` as opposed to `<type> obj`;
# it doesn't make a difference, but we want to be internally consistent.
# Note: this grep pattern is (intended to be) equivalent to the python
Expand Down