Skip to content

Avoid bare pytest.raises in dtypes/cast/test_upcast.py #32603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 11, 2020
Merged

Avoid bare pytest.raises in dtypes/cast/test_upcast.py #32603

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e88e88f
Beginning work on fixing the bare pytest raises
Mar 6, 2020
cf2e539
Little over halfway done with this file now.
Mar 6, 2020
f7aa10c
Almost done!
Mar 6, 2020
8f7ed89
Finished the file!
Mar 6, 2020
8b6acaf
Blacked
Mar 6, 2020
117d195
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 6, 2020
77b1066
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 10, 2020
aa6616c
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 11, 2020
fe1ec54
Adding message check to pytest.raises for test_upcast
Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/tests/dtypes/cast/test_upcast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def test_upcast_error(result):
# GH23823 require result arg to be ndarray
mask = np.array([False, True, False])
other = np.array([61, 62, 63])
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="The result input must be a ndarray"):
result, _ = maybe_upcast_putmask(result, mask, other)


Expand Down