REF: implement nanops.na_accum_func #32597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomAugspurger thoughts on whether we're going to do a 1.0.3? if so i should hold off on refactors like this |
jreback
reviewed
Mar 11, 2020
There was a problem hiding this comment.
@TomAugspurger thoughts on whether we're going to do a 1.0.3? if so i should hold off on refactors like this
this is for 1.1 right?
pandas/core/nanops.py
Outdated
| @@ -1497,3 +1497,62 @@ def nanpercentile( | |||
| return result | |||
| else: | |||
| return np.percentile(values, q, axis=axis, interpolation=interpolation) | |||
|
|
|||
|
|
|||
| def na_accum_func(values, accum_func, skipna: bool): | |||
jreback
added
Missing-data
|
I'm not sure if we're doing a 1.0.3. Will talk about it on the call today.
…On Tue, Mar 10, 2020 at 9:46 PM Jeff Reback ***@***.***> wrote:
***@***.**** commented on this pull request.
@TomAugspurger <https://github.com/TomAugspurger> thoughts on whether
we're going to do a 1.0.3? if so i should hold off on refactors like this
this is for 1.1 right?
------------------------------
In pandas/core/nanops.py
<#32597 (comment)>:
> @@ -1497,3 +1497,62 @@ def nanpercentile(
return result
else:
return np.percentile(values, q, axis=axis, interpolation=interpolation)
+
+
+def na_accum_func(values, accum_func, skipna: bool):
can you add a doc-string
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32597?email_source=notifications&email_token=AAKAOIVVSZIWQKSDNGM73RDRG33RFA5CNFSM4LFIRB5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYZQZ5I#pullrequestreview-372444405>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIXADB3VJZCG723LK6DRG33RFANCNFSM4LFIRB5A>
.
|
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow-up that was requested a few months ago