Skip to content

BUG: Don't multiply sets during construction #32594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 15, 2020
Merged

BUG: Don't multiply sets during construction #32594

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d31e8c1
Test
dsaxton Mar 10, 2020
a855d11
Cast set
dsaxton Mar 10, 2020
8f13e11
Doc
dsaxton Mar 10, 2020
0e473ad
Comment
dsaxton Mar 11, 2020
7698426
Revert
dsaxton Mar 11, 2020
f35aca5
Update test
dsaxton Mar 11, 2020
699bcfc
Raise for sets
dsaxton Mar 11, 2020
5312ecd
New whatsnew
dsaxton Mar 11, 2020
69faf9d
Use abc.Set
dsaxton Mar 11, 2020
b1edc19
Merge remote-tracking branch 'upstream/master' into set-construct
dsaxton Mar 11, 2020
2cbf121
Merge remote-tracking branch 'upstream/master' into set-construct
dsaxton Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ Conversion
^^^^^^^^^^
- Bug in :class:`Series` construction from NumPy array with big-endian ``datetime64`` dtype (:issue:`29684`)
- Bug in :class:`Timedelta` construction with large nanoseconds keyword value (:issue:`32402`)
-
- Bug in :class:`DataFrame` construction where sets would be duplicated rather than raising (:issue:`32582`)

Strings
^^^^^^^
Expand Down
2 changes: 2 additions & 0 deletions pandas/core/construction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,8 @@ def sanitize_array(
# GH#16804
arr = np.arange(data.start, data.stop, data.step, dtype="int64")
subarr = _try_cast(arr, dtype, copy, raise_cast_failure)
elif isinstance(data, set):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use abc.Set

raise TypeError("Set type is unordered")
else:
subarr = _try_cast(data, dtype, copy, raise_cast_failure)

Expand Down
6 changes: 6 additions & 0 deletions pandas/tests/frame/test_constructors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,3 +2609,9 @@ def test_from_2d_ndarray_with_dtype(self):

expected = pd.DataFrame(array_dim2).astype("datetime64[ns, UTC]")
tm.assert_frame_equal(df, expected)

def test_construction_from_set_raises(self):
# https://github.com/pandas-dev/pandas/issues/32582
msg = "Set type is unordered"
with pytest.raises(TypeError, match=msg):
pd.DataFrame({"a": {1, 2, 3}})