Skip to content

DOC: Add missing question mark icon #32564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

stijnvanhoey
Copy link
Contributor

I added the question mark to the _static folder. When rebuilding the documentation pages locally using the latest version of the pydata-bootstrap-sphinx-theme, the div.highlight seems to be styled correctly (background: white), removing the strange green around the code block.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@datapythonista datapythonista changed the title Add missing question mark icon DOC: Add missing question mark icon Mar 9, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.0.2 milestone Mar 9, 2020
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Mar 9, 2020

So to understand, you forgot to include this in the initial PR, and it was unrelated to the changes in the theme?

@stijnvanhoey
Copy link
Contributor Author

With respect to the svg, I do think this must have been the case (file was ignored by default, so I had to add -f). The background of the code section seems to be a theme-related adjustment which is no longer apparent using the latest version of the theme.

@jorisvandenbossche jorisvandenbossche merged commit 76a1710 into pandas-dev:master Mar 10, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 10, 2020
jorisvandenbossche pushed a commit that referenced this pull request Mar 10, 2020
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: fix styling (css) of getting started tutorials
3 participants