TST: Add extra test for pandas.to_numeric() for issue #32394 #32560
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Numeric Operations
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Mar 9, 2020
gfyoung
reviewed
Mar 10, 2020
| def test_failure_to_convert_uint64_string_to_NaN(): | ||
| # GH 32394 | ||
| result = to_numeric("uint64", errors="coerce") | ||
| assert np.isnan(result) |
There was a problem hiding this comment.
I think this is a good test, but we generally add the OP example as a test too.
There was a problem hiding this comment.
This is basically the OP example, you know, since the first thing that to_numeric does is putting that scalar value in a object array (the bug was about the "uint64" string, not about whether it was passed as a list, series, array or scalar)
|
@roberthdevries if you can add the OP test as well here. thanks. |
roberthdevries
force-pushed
the
add-test-to_numeric_issue_32394
branch
from
b70728e to
a30d0ba
Compare
|
OP test added |
|
thanks @roberthdevries |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff