-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: retain tz in to_records #32535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: retain tz in to_records #32535
Conversation
…-internal_get_values-frame
…-internal_get_values-frame
…-internal_get_values-frame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a whatsnew
…-internal_get_values-frame
whatsnew added + green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. merge on green after comment.
@@ -18,6 +25,16 @@ def test_to_records_dt64(self): | |||
result = df.to_records()["index"][0] | |||
assert expected == result | |||
|
|||
def test_to_records_dt64tz_column(self): | |||
df = DataFrame({"A": date_range("2012-01-01", "2012-01-02", tz="US/Eastern")}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you can add the issue numbe here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated+green
…-internal_get_values-frame
…-internal_get_values-frame
* BUG: retain tz in to_records * whatsnew * woops * comment
plus the initial motivation: get rid of two of our
_internal_get_values
calls (of which i count 16 left in master)