Skip to content

BUG: retain tz in to_records #32535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jbrockmendel
Copy link
Member

plus the initial motivation: get rid of two of our _internal_get_values calls (of which i count 16 left in master)

@jreback jreback added Bug Timezones Timezone data dtype labels Mar 11, 2020
@jreback jreback added this to the 1.1 milestone Mar 11, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew

@jbrockmendel
Copy link
Member Author

whatsnew added + green

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green after comment.

@@ -18,6 +25,16 @@ def test_to_records_dt64(self):
result = df.to_records()["index"][0]
assert expected == result

def test_to_records_dt64tz_column(self):
df = DataFrame({"A": date_range("2012-01-01", "2012-01-02", tz="US/Eastern")})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you can add the issue numbe here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated+green

@jbrockmendel jbrockmendel merged commit 4603c63 into pandas-dev:master Mar 14, 2020
@jbrockmendel jbrockmendel deleted the no-internal_get_values-frame branch March 14, 2020 21:29
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
* BUG: retain tz in to_records

* whatsnew

* woops

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants