TYP: Add type hint for DataFrame.T and certain array types #32532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwhelan
force-pushed
the
transpose_type
branch
2 times, most recently
from
eeb0417 to
de3c999
Compare
WillAyd
requested changes
Mar 9, 2020
|
thanks @qwhelan |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating a large pandas codebase with type coverage to 1.0, I noticed that
DataFrame.transpose()is annotated to returnDataFramewhileDataFrame.Thas no such hint. This PR also adds hints in a few places other places where they're trivial.The definition of
pandas.core.base.IndexOpsMixIn.transpose(and associated.T) currently do not have any type hints and fixing this seems more complicated, meaningIndex.TandSeries.Tare not fixed by this PR.Happy to amend to cover that case if anyone has suggestions, but I believe
DataFrame.Tto be the vast majority of usage.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff